Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with grouping use declarations (PHP7) #919

Closed
glen-84 opened this issue Mar 14, 2016 · 2 comments
Closed

Problems with grouping use declarations (PHP7) #919

glen-84 opened this issue Mar 14, 2016 · 2 comments

Comments

@glen-84
Copy link
Contributor

glen-84 commented Mar 14, 2016

With code like this:

<?php

declare(strict_types = 1);

namespace ExpressiveExtensions;

use Psr\Http\Message\{ResponseInterface, ServerRequestInterface};
use Zend\Diactoros\Response\{HtmlResponse, JsonResponse, TextResponse};

I get:

 1 | ERROR | [ ] A file should declare new symbols (classes, functions,
   |       |     constants, etc.) and cause no other side effects, or it
   |       |     should execute logic with side effects, but should not do
   |       |     both. The first symbol is defined on line 11 and the first
   |       |     side effect is on line 7.
   |       |     (PSR1.Files.SideEffects.FoundWithSymbols)
 7 | ERROR | [x] There must be one USE keyword per declaration
   |       |     (PSR2.Namespaces.UseDeclaration.MultipleDeclarations)
 7 | ERROR | [x] Closing brace must be on a line by itself
   |       |     (Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore)
 8 | ERROR | [x] There must be one USE keyword per declaration
   |       |     (PSR2.Namespaces.UseDeclaration.MultipleDeclarations)
 8 | ERROR | [x] Closing brace must be on a line by itself
   |       |     (Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore)
@glen-84
Copy link
Contributor Author

glen-84 commented Mar 14, 2016

Sorry, I see that this is covered by #878.

When will those changes be released?

@gsherwood
Copy link
Member

I've been trying to find time for 3 weeks now. So the answer is just "as soon as I can".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants