-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCS blame reports output error content from the blame commands for files not under VC #638
Comments
Maybe, but then you'll have 2 different scopes of files scanned based on selected report, which might be confusing. |
I agree that it is confusing to have 2 different scopes basis the selected report. However these type of files are not in the repo, and they are already not part of the gitblame report, therefore it makes sense to not parse them in the gitblame report case only. In any case the error is coming from git-blame not phpcs and is bit confusing to understand what is happening and why, a better way to show the error with clearer explanation will help users would be good |
The files need to be scanned, but they are recorded as an Unknown user because the author of each line is still unknown. I'll look at just getting the VCS commands to mute their errors. |
* Add extra tests to improve code coverage * Add comment to last test in case file 3 to clarify that it must be the last in the file.
gitblame stype reports throwing
fatal: no such path 'path/to/file/' in HEAD
errors for files which exist locally but not there in repo
While
.gitignored
files can also be ignored in phpcs runs,ideally these files should not be scanned in gitblame report style in the first place
The text was updated successfully, but these errors were encountered: