PEAR.Functions.FunctionCallSignature sniff not checking all function calls

[aik099]

Code fragment:

if ( isset( $validation_data['address']) ) {
    $a = 5;
}

isset( $validation_data['address']);

If appears, that PEAR.Functions.FunctionCallSignature sniff isn't checking that there is 0 spaces after opening parenthesis of "isset" function call, when it's placed within a control structure.

After some digging I've found, that this has something to do with "isset" function call specifically. If I replace "isset" with "array_values" or "some_func", then all is reported/fixed properly.

[aik099]

Ha, apparently to PHP tokenizer "isset" isn't a function, because it's tokenized as T_ISSET token and therefore isn't considered as function call by any of the sniffs, that listen specifically for T_STRING.

Some other function calls are considered as language constructs by PHP as well, e.g.:

• T_EVAL - eval(...)
• T_EXIT - exit(...);
• T_INCLUDE - include(...);
• T_INCLUDE_ONCE - incldue_once(...);
• T_REQUIRE - require(...);
• T_REQUIRE_ONCE - require_once(...);
• T_ISSET - isset(...);
• T_UNSET - unset(...);
• T_EMPTY - empty(...);

There are also T_ECHO and T_PRINT, but they surely aren't functions at all.

[JDGrimes]

• T_EMPTY - empty( ... );

[aik099]

Thanks @JDGrimes , I've updated my original comment.

[gsherwood]

Yep, those special tokens are a real pain. This is fixed now.

[pfrenssen]

isset() is not a function, but a language construct.

$ php -a
php > $function = 'isset';
php > $function('test');
PHP Warning:  Uncaught Error: Call to undefined function isset() in php shell code:1

[gsherwood]

isset() is not a function, but a language construct.

In this case, it is called like a function and so the same formatting rules apply.