Multiple catch blocks not checked in Squiz.ControlStructures.ControlSignature sniff

[fbourigault]

In PSR2, multiple catches block must be like this:

<?php
try {
    // try body
} catch (FirstExceptionType $e) {
    // catch body
} catch (OtherExceptionType $e) {
    // catch body
}

but phpcs --standard-PSR2 is ok with the following code:

<?php
try {
    // try body
} catch (FirstExceptionType $e) {
    // catch body
}
catch (OtherExceptionType $e) {
    // catch body
}

Bug is present in 2.3.0 and master

[aik099]

Appears like catch statement formatting isn't checked at all. Can you please post a link in the PSR-2 specification where it describes how catch should be formatted?

[fbourigault]

When you run phpcs --standard=PSR2 against the following code, it throw this error: Expected 1 space after closing brace; newline found

<?php
try {
    // try body
}
catch (FirstExceptionType $e) {
    // catch body
}

PSR2 about try, catch : https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#56-try-catch

[aik099]

I see. The subsequential catch statements are ignored then.

[gsherwood]

Thanks for reporting this. It has been fixed now.