Add ignoreNewlines option to Squiz.Strings.ConcatenationSpacing sniff

[Pittiplatsch]

$a = 1+2;
$a = 1.2;

For the first assignment, missing spaces are announced, whilst the second assignment illegally passes.

IMO T_STRING_CONCAT token must be checked as well.

[aik099]

Because there is dedicated sniff for that called Squiz.Strings.ConcatenationSpacing.

[Pittiplatsch]

Thx for the hint :-) Didn't even think of the possibility for a separate sniff.
However, Squiz.Strings.ConcatenationSpacing doesn't work for me: Configuring exactly one space correctly lets the following pass:
$a = '1' . '2';
but fails on:

$a = 'very'
    . 'long'
    . generateSomeEvenLongerTextSnippet()
    . '!';

because of the newlines :-(

[aik099]

Yes, new lines is another topic I'm afraid. The Squiz.WhiteSpace.OperatorSpacing also had problems with new lines and with the help of @gsherwood we're able to allow it to skip validation in such case.

I've developed my own sniff for string concatenation validation/fixing for that reason: https://github.com/aik099/CodingStandard/blob/master/CodingStandard/Sniffs/Strings/ConcatenationSpacingSniff.php

[Pittiplatsch]

Just stumbled upon bfbdc6a as a follow-up on #348 which claims to fix the newline issue for Squiz.WhiteSpace.OperatorSpacing.

@gsherwood Could you please apply that fix to Squiz.Strings.ConcatenationSpacing (and maybe other similar sniffs) as well? Maybe even to #460 as well 😄

[gsherwood]

I've added the ignoreNewlines option to the sniff. Like the other one, it doesn't care where you place the concat operators, so you'd need to write a custom sniff if you want them (for example) aligned.

[Pittiplatsch]

Thank you a lot 😄