Sniff-specific exclude patterns don't work for Windows

[Pittiplatsch]

This bug was already mentioned in http://pear.php.net/bugs/bug.php?id=20369 but wasn't completely fixed.
I don't completely understand all the internals, but I could break it down to
https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/File.php#L547
where the DIRECTOR_SEPARATOR replacement (and the other "convenient" replacements like \ => \\) , which is performed for global exclusions in https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer.php#L1566, is still missing.

[gsherwood]

You were right - that slash replacement was missing. I also added it into addWarning because it was missing there as well. Thanks for the report.

[Pittiplatsch]

Thx for fixing that.
However I think, a refactoring leading to encapsulation of the complete pattern handling is inevitable here, as it is used at so many places...

[gsherwood]

However I think, a refactoring leading to encapsulation of the complete pattern handling is inevitable here, as it is used at so many places...

I have the same thought, just not the time right now.