PHP path can't be determined in some cases in "phpcs.bat" (on Windows XP)

[aik099]

When on Windows XP, then PHP isn't correctly detected in https://github.com/squizlabs/PHP_CodeSniffer/blob/master/scripts/phpcs.bat file. I recommend using more sophisticated approach in PHP detection used in PHP MessDetector library: https://github.com/phpmd/phpmd/blob/master/src/bin/phpmd.bat

[billschaller]

I think this isn't just a WinXP issue.

[aik099]

Since PHP MessDetector implementation also looks in PEAR installation folder (when present), then it's surely more error prone specifically in cases, when PHP wasn't installed via installation (e.g. PHP 5.3 doesn't have installator).

[aik099]

@gmgj , are you sure it's not a different issue? My issue isn't just fixing any possible issue on Windows 😄

I guess there is something with windows temp folder detection because that diff shouldn't have been created at c:\.

[aik099]

@gmgj , I've retitled task to express the issue more clearly. Thanks for noticing it.

[gsherwood]

PHP detection is working fine on my Windows test box, so I can't test that the fix actually worked. I've committed the changed .bat format for phpcs and phpcbf and confirmed it is still working for me, so it would be great if you could also test it and let me know if that format is working for you.

[aik099]

How can I test that? To my knowledge PEAR doesn't allow you to install package at specific branch/commit.

[aik099]

Maybe I can just grab phpcs.bat and replace one I already have and see what happens?

[gsherwood]

You can clone the repo and then do:

pear uninstall PHP_CodeSniffer
pear install package.xml

That will install the latest code for you.

[aik099]

Nope. It doesn't work. Here is what I get when I run "phpcs" (which runs "phpcs.bat") in the PHP folder:

[gsherwood]

Did you install it via PEAR or just replace the .bat file? The PEAR installer replaces @bin_dir@, so the install couldn't have worked properly.

[aik099]

Ups. I've replaced bat file. I've manually replaced the @bin_dir@ and now all works, thanks.