Syntax error in JS file can cause undefined index for parenthesis_closer

[jnwarp]

When running code checks on my repository, a PHP Notice is produced.

PHP Notice: Undefined index: parenthesis_closer in C:\Users\ajame\Documents\runner-test\vendor\squizlabs\php_codesniffer\CodeSniffer\File.php on line 3321

The error is found in this function:

public function findPrevious(
        $types,
        $start,
        $end=null,
        $exclude=false,
        $value=null,
        $local=false
    ) {
        $types = (array) $types;

        if ($end === null) {
            $end = 0;
        }

        for ($i = $start; $i >= $end; $i--) {
            $found = (bool) $exclude;
            foreach ($types as $type) {
                if ($this->_tokens[$i]['code'] === $type) {
                    $found = !$exclude;
                    break;
                }
            }

            if ($found === true) {
                if ($value === null) {
                    return $i;
                } else if ($this->_tokens[$i]['content'] === $value) {
                    return $i;
                }
            }

            if ($local === true) {
                if (isset($this->_tokens[$i]['scope_opener']) === true
                    && $i === $this->_tokens[$i]['scope_closer']
                ) {
                    $i = $this->_tokens[$i]['scope_opener'];
                } else if (isset($this->_tokens[$i]['bracket_opener']) === true
                    && $i === $this->_tokens[$i]['bracket_closer']
                ) {
                    $i = $this->_tokens[$i]['bracket_opener'];
                } else if (isset($this->_tokens[$i]['parenthesis_opener']) === true
                    && $i === $this->_tokens[$i]['parenthesis_closer']
                ) {
                    $i = $this->_tokens[$i]['parenthesis_opener'];
                } else if ($this->_tokens[$i]['code'] === T_SEMICOLON) {
                    break;
                }
            }
        }//end for

        return false;

    }//end findPrevious()

The error is produced by this invalid javascript file:

$(document).ready(function () {
  console.log('hello world');
}

Notice the missing ); at the end of the $(document).ready.

[aik099]

Which version of PHP_CodeSniffer are you using? Does the same happen in master as well?

[jnwarp]

I am using version 2.6.0 installed through composer. If I set composer to download the version from the master branch, the error persists.

PHP Notice: Undefined index: parenthesis_closer in C:\Users\ajame\Documents\gitlab-runner-test\vendor\squizlabs\php_codesniffer\CodeSniffer\File.php on line 3310

[gsherwood]

This has been fixed now. Thanks for reporting it.