Fixed bug #938 : CallTimePassByReferenceSniff ignores functions with …

…return value
squizlabs · Mar 29, 2016 · d841a8e · d841a8e
1 parent 884a8ae
commit d841a8e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/CodeSniffer/Standards/Generic/Sniffs/Functions/CallTimePassByReferenceSniff.php b/CodeSniffer/Standards/Generic/Sniffs/Functions/CallTimePassByReferenceSniff.php
@@ -68,12 +68,8 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
         // within their definitions. For example: function myFunction...
         // "myFunction" is T_STRING but we should skip because it is not a
         // function or method *call*.
-        // Also skip if the return value is being assigned to a variable.
         $prevCode = $tokens[$prev]['code'];
-        if ($prevCode === T_FUNCTION
-            || $prevCode === T_CLASS
-            || isset(PHP_CodeSniffer_Tokens::$assignmentTokens[$prevCode]) === true
-        ) {
+        if ($prevCode === T_FUNCTION || $prevCode === T_CLASS) {
             return;
         }
 

diff --git a/package.xml b/package.xml
@@ -82,6 +82,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Fixed bug #928 : Endless loop when sniffing a PHP file with a git merge conflict inside a function
   - Fixed bug #937 : Shebang can cause PSR1 SideEffects warning
     -- Thanks to Clay Loveless for the patch
+  - Fixed bug #938 : CallTimePassByReferenceSniff ignores functions with return value
  </notes>
  <contents>
   <dir name="/">