Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing Italian localization #3224

Merged
merged 5 commits into from
Nov 15, 2021
Merged

added missing Italian localization #3224

merged 5 commits into from
Nov 15, 2021

Conversation

aborruso
Copy link
Contributor

No description provided.

@aborruso aborruso changed the title added back to top Italian localization added missing Italian localization Nov 14, 2021
squidfunk
squidfunk requested changes Nov 14, 2021
View reviewed changes
src/partials/languages/it.html Outdated
@@ -41,5 +41,22 @@
"source.revision.date": "Ultimo aggiornamento",
"source.file.date.updated": "Ultimo aggiornamento",
"source.file.date.created": "Creata",
"toc.title": "Indice"
"toc.title": "Indice",
"direction": "ltr",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put the keys in the same order as in the en.html?

Copy link
Contributor Author

@aborruso aborruso Nov 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you

squidfunk
squidfunk requested changes Nov 14, 2021
View reviewed changes
src/partials/languages/it.html Outdated
"search.config.lang": "it",
"search.config.pipeline": "trimmer, stopWordFilter",
Copy link
Owner

@squidfunk squidfunk Nov 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect :-) This line and the next are not necessary, as they are the same as in en.html. They can be removed. Otherwise, this is ready for merge! Please remove:

  • search.config.pipeline
  • search.config.separator

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you

@squidfunk squidfunk merged commit d51279a into squidfunk:master Nov 15, 2021
@squidfunk
Copy link
Owner

Perfect, thanks again!

@aborruso
Copy link
Contributor Author

Perfect, thanks again!

it is a pleasure and an honor

@aborruso
Copy link
Contributor Author

Perfect, thanks again!

A question: I have a GitHub action to deploy in GitHub. If I run it I will have these new localizations? Must I force this in some way?

Thank you

@squidfunk
Copy link
Owner

squidfunk commented Nov 15, 2021 •
edited
Loading

If you clone from git, yes. Otherwise no, because the changes are not released yet. As we're on our way to version 8 (see #3219), I'm going to release those changes in 8.0.0b2, which should follow this weekend. In the mean time you can install from git:

pip install git+https://github.com/squidfunk/mkdocs-material.git

tIsGoud added a commit to tIsGoud/mkdocs-material that referenced this pull request Nov 19, 2021
@tIsGoud
Update to upstream release 8.0.0b1
ecd05da 
* upstream/master:
  Updated Italian translations (squidfunk#3224)
  Added note on new beta to getting started guide
  Documentation
  Updated Insiders documentation
  Updated dependencies
  Updated Greek translation (squidfunk#3191)
  Updated GitHub Pages documentation (squidfunk#3207)
  Added new sponsor: Prefect
@aborruso
Copy link
Contributor Author

If you clone from git, yes. Otherwise no, because the changes are not released yet. As we're on our way to version 8 (see #3219), I'm going to release those changes in 8.0.0b2, which should follow this weekend.

@squidfunk we have the 8.0.0b2, but I have still the "Back to top" English label. Is it normal?

This is my github action.

Thank you

image

@squidfunk
Copy link
Owner

squidfunk commented Nov 24, 2021 •
edited
Loading

It's still only in master, not in the v8 branch. I'll merge it as soon as that is possible. In the meantime you can either use master when you want to use 7.3.6, or use custom translations when you want to use 8.0.0b2. Sorry for the inconvenience but 8.0.0b2 has a very huge diff from master. I only want to do the merging once before the RC.

@aborruso
Copy link
Contributor Author

I don't think I understand. Sorry. In my github action I install simply mkdocs-material via pip. In this case I guess then the master is installed. You say that it's still only in the master, but I do not have these new Italian labels on my site?

What I did not understand? What am I doing wrong?

Thank you

@martinbira
Copy link
Contributor

martinbira commented Nov 24, 2021 •
edited
Loading

I don't think I understand. Sorry. In my github action I install simply mkdocs-material via pip. In this case I guess then the master is installed. You say that it's still only in the master, but I do not have these new Italian labels on my site?

What I did not understand? What am I doing wrong?

It is in the master for version 8.x.x, which is not released yet, so it is not available in the latest 7.3.6 release that you get from installing mkdocs-material. It will be available when version 8 is released.

@squidfunk
Copy link
Owner

squidfunk commented Nov 24, 2021 •
edited
Loading

The changes were commited to master after the 7.3.6 release, but master was not merged into 8.0.0 yet. Thus, you have to either install from git or use custom translations for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidfunk squidfunk squidfunk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aborruso @squidfunk @martinbira