Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py: minor indent fix #2078

Merged
merged 2 commits into from
Nov 30, 2020
Merged

setup.py: minor indent fix #2078

merged 2 commits into from
Nov 30, 2020

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Nov 30, 2020 •
edited
Loading

Fixes an indent issue.

@RDIL
setup.py: comply with Python style guide
b08bbf4 
Signed-off-by: Reece Dunham <me@rdil.rocks>
@squidfunk
Copy link
Owner

Is there any downside on not complying? 😅

@facelessuser
Copy link
Contributor

No, but I'd fix your indentation issue at the very least. Everything else is personal preference.

@RDIL
Copy link
Contributor Author

RDIL commented Nov 30, 2020

@facelessuser is correct. I'm happy to revert the rest, just lmk.

@squidfunk
Copy link
Owner

Jep, indentation should be fixed. I'm not very happy with the rest, as it's less readable.

@RDIL RDIL changed the title setup.py: comply with Python style guide setup.py: minor indent fix Nov 30, 2020
@RDIL
Copy link
Contributor Author

RDIL commented Nov 30, 2020

Fixed @squidfunk 😄

@squidfunk
Copy link
Owner

Thanks!

@squidfunk squidfunk merged commit 8b2d28a into squidfunk:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RDIL @squidfunk @facelessuser