Fixed privacy plugin not replacing occurrences

squidfunk · Mar 1, 2025 · 523922b · 523922b
1 parent 3bd81bd
commit 523922b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/material/plugins/privacy/plugin.py b/material/plugins/privacy/plugin.py
@@ -433,7 +433,7 @@ def _fetch(self, file: File, config: MkDocsConfig):
             # Intercept errors of type `ConnectionError` and `HTTPError`
             except Exception as error:
                 log.warning(f"Couldn't retrieve {file.url}: {error}")
-                return
+                return False
 
             # Compute expected file extension and append if missing
             mime = res.headers["content-type"].split(";")[0]
@@ -484,6 +484,9 @@ def _fetch(self, file: File, config: MkDocsConfig):
             if not self._is_excluded(url, file):
                 self._queue(url, config, concurrent = True)
 
+        # External asset was successfully downloaded
+        return True
+
     # Patch all links to external assets in the given file
     def _patch(self, initiator: File):
         with open(initiator.abs_src_path, encoding = "utf-8-sig") as f:

diff --git a/src/plugins/privacy/plugin.py b/src/plugins/privacy/plugin.py
@@ -433,7 +433,7 @@ def _fetch(self, file: File, config: MkDocsConfig):
             # Intercept errors of type `ConnectionError` and `HTTPError`
             except Exception as error:
                 log.warning(f"Couldn't retrieve {file.url}: {error}")
-                return
+                return False
 
             # Compute expected file extension and append if missing
             mime = res.headers["content-type"].split(";")[0]
@@ -484,6 +484,9 @@ def _fetch(self, file: File, config: MkDocsConfig):
             if not self._is_excluded(url, file):
                 self._queue(url, config, concurrent = True)
 
+        # External asset was successfully downloaded
+        return True
+
     # Patch all links to external assets in the given file
     def _patch(self, initiator: File):
         with open(initiator.abs_src_path, encoding = "utf-8-sig") as f: