Skip to content

Fix -Wsign-compare on arm32 #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kinkie wants to merge 4 commits into from
+2 −1
Closed

Fix -Wsign-compare on arm32 #2432

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40af8fc
Refactor peerDigestSwapInMask for 32-bit safety
kinkie Jun 2, 2026
1b23e7d
use size_t
kinkie Jun 2, 2026
0885264
add a defensive check
kinkie Jun 2, 2026
0f3a857
correct check
kinkie Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/peer_digest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,8 @@ peerDigestSwapInMask(void *data, char *buf, ssize_t size)
* we need to do the copy ourselves!
*/
Assure(size >= 0);
if (fetch->mask_offset + size > static_cast<ssize_t>(pd->cd->mask_size)) {
Assure(pd->cd->mask_size >= fetch->mask_offset);
if (static_cast<size_t>(size) > pd->cd->mask_size - fetch->mask_offset) {
finishAndDeleteFetch(fetch, "peer digest mask data too large", true);
return -1;
}
Expand Down
Loading