-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit valid YAML for cachemgr:server_list #1735
Open
kinkie
wants to merge
140
commits into
squid-cache:master
Choose a base branch
from
kinkie:packablestream-dump_peers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
140 commits
Select commit
Hold shift + click to select a range
71ae5e0
Use PackableStream for dump_peers
kinkie 57d511e
Fix formatting
kinkie 8441c91
Source maintenance
kinkie b411cee
dump_peer_options -> CachePeer::dumpOptions
kinkie 5a46e40
neighborTypeStr -> CachePeer::typeString
kinkie cd395c9
dump_peers internals -> CachePeer::reportStatistics
kinkie 0533486
Source maintenance
kinkie d99bc9e
fix typo
kinkie d0e4b1b
Move newline at end of CachePeer::dumpOptions to callers
kinkie 321a664
move opening newline in reportStatistics()
kinkie 40d7295
Reposition newline
kinkie aec3b06
Apply suggestions from code review
kinkie f1e5848
fix const
kinkie 50959d5
Do not consider current configuration to output stats
kinkie 5486566
Reorder CachePeer::typeString position
kinkie cc0587d
Steamline output
kinkie 58759f6
Move away from all caps
kinkie 0513961
Simplified htcp options output
kinkie 29cc51d
ESI: Disable by default (#1728)
yadij 1bd2839
Maintenance: update --with-expat detection (#1726)
yadij add5c37
Maintenance: update --with-xml2 detection (#1727)
yadij 8c60968
Convert hostname_aliases to SBufList (#1737)
yadij 6621681
Convert loadable_modules to SBufList (#1738)
yadij d438cbd
Docs: Update CREDITS after code removals (#1741)
yadij f017aa6
Maintenance: update --with-ldap detection (#1736)
yadij 5549d49
NoNewGlobals: HttpUpgradeProtocolAccess::ProtoOther (#1745)
kinkie bf6d60d
Maintenance: rework SASL detection (#1694)
kinkie 1c86e94
NoNewGlobals for digestFieldsLookupTable (#1743)
kinkie cc0af08
NoNewGlobals for MapLabel (#1746)
kinkie 077739a
Make BodyPipe::MaxCapacity constexpr (#1748)
kinkie cf26d14
HTTP: Protect just-parsed responses from accidental destruction (#1752)
eduard-bagdasaryan 5846e46
Maintenance: Updated CONTRIBUTORS (#1758)
rousskov 75f6f90
Source Format Enforcement (#1759)
rousskov 5a1d721
Refactor portions of getCurrentTime() to use std::chrono (#1755)
yadij d041311
CI: Require source-maintenance.sh application before merging PRs (#1760)
rousskov 1f63940
NoNewGlobals for Adaptation::Config::metaHeaders (#1747)
kinkie 9caa73c
Bug 5360: FwdState::noteDestinationsEnd() assertion "err" (#1767)
rousskov 2da7be6
scripts/find-alive.pl: Auto-detect auto-added ctors/dtors names (#1769)
rousskov 5d18dc5
Fix heap buffer overead in ConfigParser::UnQuote() (#1763)
xiaoxiaoafeifei 58dc0c2
Do not blame cache_peer for CONNECT errors (#1772)
rousskov 820fea5
Fix const-correctness of ACLHTTPHeaderData::match() parameter (#1771)
rousskov 821dfa0
Fix eCAP header includes (#1753)
yadij ab47a24
Maintenance: Remove several unused files (#1773)
yadij ac9be5a
Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE (#1774)
yadij 2429915
NoNewGlobals for MemBlob::Stats (#1749)
kinkie f3c04a9
Refactor and improve ErrorState::Dump (#1730)
kinkie 1259975
Add AtMostOnce stream manipulator (#1742)
kinkie 5f4a399
NoNewGlobals for HttpHdrCc:ccLookupTable (#1750)
kinkie 604cd65
Start using YAML for output
kinkie 72817a0
Emit valid YAML
kinkie 3a42f6a
ESI: Disable by default (#1728)
yadij 4220d5b
Maintenance: update --with-expat detection (#1726)
yadij 1ceadc3
Maintenance: update --with-xml2 detection (#1727)
yadij 82bb087
Maintenance: update --with-ldap detection (#1736)
yadij bd6ebd7
Maintenance: rework SASL detection (#1694)
kinkie 0961747
Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE (#1774)
yadij bda0dde
Merge remote-tracking branch 'upstream/master' into packablestream-du…
kinkie 9fddf43
Source format
kinkie 9f8b603
do not set FP precision on ICP counts
kinkie 76e9b04
Do not capitalize CachePeer::typeString
kinkie 3b7ec1d
Fix addresses
kinkie 3a21504
Make output a map, rename stream to yaml
kinkie 9f07570
Add sbuf/Spaces.h
kinkie 2448b34
Souce maintenance
kinkie 94edad0
Implement and use spaces() in YAML output
kinkie a777f8a
Do not report default connection-auh=auto
kinkie 3351a20
Formatting change
kinkie 8300fe7
rename stream back
kinkie 32da730
Upgrade Acl::Node::name to SBuf; remove AclMatchedName global (#1766)
rousskov 19905ac
Maintenance: update --with-tdb detection (#1776)
yadij 5f5351c
add AsList::quotedBy()
kinkie add11ab
Make AsList data members private
kinkie 85ca4d8
add default quote character; rename quotedBy to quoted
kinkie 1a71ac4
fixup: Polished new method description
rousskov a2c83f7
fixup: We do not return stream from modern print() methods
rousskov 3a29fdd
fixup: Fix official operator "<<" declaration inconsistency
rousskov ed07caa
fixup: Do not abuse empty strings to disable printing
rousskov 256c9bd
fixup: Improved formatting of modified code
rousskov 0833859
fixup: Undo out-of-scope controversial member visibility change
rousskov 7524293
fixup: Removed the last two stale quotedBy() occurrences
rousskov cc51eba
fixup: Fixed my comment spelling mistake
rousskov f35d5d8
Merge remote-tracking branch 'upstream/master' into packablestream-du…
kinkie ec92b7b
neighbors.cc: ostream os -> yaml
kinkie 39ddf88
fix wrongly named ostream
kinkie c4274d8
add missing header in Spaces.cc
kinkie 62c5a3a
Add "icp" prefix for icp opcodes
kinkie 1d10221
use aslist.quoted() for addresses list
kinkie 4798ca0
use list instead of map for peers
kinkie 38d2505
Fix output when there are no peers configured
kinkie 781cc65
flags -> options
kinkie cc15427
separate http and icp addresses
kinkie 6e0c391
use equality test
kinkie 49eb09e
fix formatting
kinkie 2886965
Merge branch 'master' into packablestream-dump_peers
kinkie 648f7a9
Make CachePeer::reportStatistics const
kinkie 5552cca
remove "icp " prefix for ICP opcodes output
kinkie eff7ce7
capitalize protocol names in output
kinkie bf1721c
simplify address output iteration
kinkie e5f2cc0
std::vector must have a non-const, non-volatile value_type
kinkie 3dbe088
add missing spaces, quote name
kinkie 6756fdd
use application/yaml content-type
kinkie 055d5b4
Bug 5352: Do not get stuck when RESPMOD is slower than read(2) (#1777)
rousskov cd0df03
NoNewGlobals for cache_mem_map (#1781)
kinkie 6a82c3c
CI: Update GitHub actions/checkout to v4 (#1786)
kinkie 89e1fd4
Format mgr:pconn as YAML (#1780)
kinkie 9b687a9
NoNewGlobals for ProxyProtocol::*::Magic (#1791)
kinkie e3df547
Add MacOS to Github Actions CI tests (#1785)
kinkie fef39e1
Optimization: DiskThreadsDiskFile::readDone copied request ptr (#1798)
kinkie 9ac4f59
Optimization: DelayId::compositePosition() copied position ptr (#1799)
kinkie 8d87059
Optimization: DelayUser::Id constructor copied user pointers (#1800)
kinkie bb7b7a7
Optimization: clientBeginRequest() call copied streamData ptr (#1797)
kinkie 9f52635
Optimization: Fs::Ufs::RebuildState constructor copied dir ptr (#1802)
kinkie 0ee8e5a
Optimization: esiChoose constructor call copied parent pointer (#1803)
kinkie 7c91d7c
CI: better parallelism for functionality-test build (#1805)
kinkie a9a75f9
Optimization: clientStreamInit() copied ClientStreamData (#1801)
kinkie 94667af
Bug 5322: Do not leak HttpReply when checking http_reply_access (#1764)
rousskov 1262e4c
Maintenance: No ptr copy in future CredentialsCache::insert()s (#1807)
kinkie f409314
CI: Build layers independently to speed up GitHub Actions tests (#1787)
kinkie 15cd2b0
CI: Add clang to GitHub Actions build-tests matrix (#1812)
kinkie 33fbd13
Ensure ACLChecklist::markFinished() is called (#1809)
eduard-bagdasaryan 6366db1
Fix build with clang v18 [-Wvla-cxx-extension] (#1813)
kinkie b5634cf
Docs: REQUIRED in ident_regex, proxy_auth_regex, ext_user_regex (#1818)
rousskov 5c0e9cb
testRandomUuid: use cppunit exception tests (#1814)
kinkie 838fe55
testCacheManager: use cppunit exception tests (#1811)
kinkie 586deea
testHttpRange: use cppunit framework (#1816)
kinkie a442dd2
MinGW: fix error: cannot convert 'size_t*' to 'int*' (#1822)
yadij 3aa043e
MinGW: Fix error: cannot convert 'const int*' to 'const char*' (#1824)
yadij e92f60e
annotate_client and annotate_transaction ACLs must always match (#1820)
eduard-bagdasaryan 0250a81
MinGW: Fix error: cannot convert 'size_t*' to 'int*' (#1825)
yadij 361e3af
Remove Ident protocol support (#1827)
eduard-bagdasaryan beacb50
Bug 5378: type mismatch in libTrie (#1830)
kinkie a3364af
Improve ErrorState debugging (#1768)
rousskov 1078d2c
Do not die when parsing obsolete log_access and log_icap (#1832)
rousskov 1d7b5e1
Maintenance: Remove debug_log wrapper (#1833)
yadij 91ab954
Allocate fast-checking ACLFilledChecklists on stack (#1835)
eduard-bagdasaryan 10045b2
mkrelease: allow two digits for minor release numbers (#1837)
kinkie 2125983
Fix reporting of unrecognized directives (#1841)
rousskov 7e15c2f
Fix SMP mgr:userhash, mgr:sourcehash, and mgr:carp reports (#1844)
rousskov a869ae2
fix merge issues
kinkie 449f63c
Merge remote-tracking branch 'upstream/master' into packablestream-du…
kinkie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
capitalize protocol names in output
- Loading branch information
commit eff7ce732343bb60d14a5b9010a97fe769a23f94
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host
can be an IP address. I assumehost
is bracketed when it is an IPv6 address (if not, that is another problem to fix in this or prerequisite PR because we print:port
after the host value).We quote() IP addresses in the
addresses
field below. I am guessing that we do that because:
and/or[
characters in an IPv6 address (if we are bracketing those addresses) must be quoted to remain YAML-compliant. Please adjust (this code and/or addresses printing code) to be consistent and YAML-compliant.