Adds particleRotation and particleRotationSpread #16
Conversation
Addresses issue squarefeet#14. Attempted to follow current conventions but it is likely users will want more control over rotation.
|
Nice one, dude. I'll take a look over this within the next few days. At first glance it looks all good - thanks for sticking to the style :) Stemkoski was experimenting with aligning a particle's angle to its velocity - all of that stuff is in the 'dev' branch if you want to take a peek. His original pull req is here. What I'll probably do is merge this into a new branch to make sure it's all good, then merge into master and bump the version number (adding credit, of course). Then once Stemkoski and I have the time to finish up the angle-aligning stuff (it's very close!), I'll merge the dev branch. Sound good? |
|
PS. Regarding the corners on particles - it does sound like it's a tex tiling issue. Let me know how you get on. |
|
It was indeed because of the tiling. |
|
I get unpredicted results on the dev branch with a emitter type disk. my particles shoot out even though speed is zero. |
|
Yeah, that'll be the gravity stuff I was playing around with. It is a dev On 9 January 2014 06:24, Andrew Ray notifications@github.com wrote:
|
|
Ah. In the future, unfinished code should be in its own branch, and merged to dev when it is 100% working. Otherwise other people branching off dev for development could get hosed by broken code. |
|
Noted. |
Addresses issue squarefeet#16. Take two, this time off of dev taking into account stemkoski's changes. Updates readme to include angleAlignVelocity
Addresses issue squarefeet#16. Take two, this time off of dev taking into account stemkoski's changes. Updates readme to include angleAlignVelocity
2 participants
Addresses issue #14. Attempted to follow current conventions but it is
likely users will want more control over rotation.
I don't think this is quite ready because I see corners appearing on the rotated particles. need to investigate the 2d sampler. Possibly it's because I have particle texture tiling turned on and just need to turn it off.