Skip to content

Conversation

@sinnec
Copy link
Contributor

@sinnec sinnec commented Jan 17, 2023

Edit: This PR brings the following changes:

  • Chnages color to whitebox turquoise.
  • (Probably) Fixes link references.
  • Adds example notebooks
  • Additions to docs and README
  • Refactoring

Screenshot 2023-01-17 at 17 17 15

I'll add more markdown text, but how does it seem as a first iteration?

@sinnec sinnec marked this pull request as draft January 17, 2023 15:47
@NickNtamp
Copy link
Contributor

@sinnec I made a quick review.
First of all seems that the installation of mkdocs-jupyter is necessary. In my case this worked only with conda and not with pip.
Also I believe that there is a lot of pending work in the notebook. We have to enhance it with comments and markdown cells in order to be self-explainable. I can help you on this if you wish!!!!

@sinnec
Copy link
Contributor Author

sinnec commented Jan 18, 2023

@NickNtamp Weird because I used pip to install it. Do you believe we could combine the SDK documentation with the notebook, because their content is almost identical?

@NickNtamp
Copy link
Contributor

@NickNtamp Weird because I used pip to install it. Do you believe we could combine the SDK documentation with the notebook, because their content is almost identical?

As it is the 1st iteration, seems fine for me.

@stavrostheocharis
Copy link
Contributor

I also validate that had to install the "mkdocs-jupyter" in order to run it.

To tell you the truth I don not like very much as it is depicted as notebook inside the docs (just personal view).
Maybe if we could include the notebooks inside the repo and reference them inside the docs?
They do something similar in mlflow docs:
image

And maybe just have the code in a table as depicted below? (also to mention somewhere "Python")
image

@sinnec
Copy link
Contributor Author

sinnec commented Jan 18, 2023

@stavrostheocharis Well, the code exists in the "Using Whitebox" section and the descriptions provided are more detailed than some comments. It's almost identical (at least the one I made). I don't reject that thought of just referencing the notebooks, also given the fact that they look kinda ugly in the docs. Not all markdown can be applied on them. I made a sample one if you ewant to check out and we can decide on what we want to do and continue with that.

I personally prefer a folder with notebooks that's dettached from the docs. Your thoughts @NickNtamp @momegas ?

@sinnec
Copy link
Contributor Author

sinnec commented Jan 18, 2023

See the sections "Using Whitebox" and the mispelled "Notebooks/Usaging Whitebox" under the tutorial section. They tell the same story but one looks uglier!

@NickNtamp
Copy link
Contributor

@stavrostheocharis Well, the code exists in the "Using Whitebox" section and the descriptions provided are more detailed than some comments. It's almost identical (at least the one I made). I don't reject that thought of just referencing the notebooks, also given the fact that they look kinda ugly in the docs. Not all markdown can be applied on them. I made a sample one if you ewant to check out and we can decide on what we want to do and continue with that.

I personally prefer a folder with notebooks that's dettached from the docs. Your thoughts @NickNtamp @momegas ?

As it is a first iteration i like it @sinnec. The only bizarre thing is that, ok...we do this for what reason? I mean we create a model, load a training and inference dataset and then what? I think that we have to give something at the end (e.g. use the UI, go to page http... etc.)

@sinnec sinnec changed the title Jupyter notebooks in tutorials Add more documentation and notebooks Jan 25, 2023
@sinnec sinnec assigned sinnec and unassigned sinnec Jan 25, 2023
@sinnec sinnec marked this pull request as ready for review January 25, 2023 14:56
@sinnec sinnec requested a review from gcharis January 25, 2023 14:56
@NickNtamp NickNtamp requested review from NickNtamp and removed request for stavrostheocharis January 26, 2023 07:49
Copy link
Contributor

@NickNtamp NickNtamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work @sinnec . Some links are missing, especially in metrics etc but I can fill them, working in the other PR for the regression models. Ok from my side.

@sinnec
Copy link
Contributor Author

sinnec commented Jan 26, 2023

I know that there are missing links. After the doc's restructure I didn't know where they should point and since I don't know if they will work, I omitted them. 😊

@gcharis gcharis merged commit 298e1d2 into main Jan 26, 2023
@sinnec sinnec deleted the mkdocs-jupyter branch January 26, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Roadmap] Add example notebooks in the repo and docs and embed them in docs

5 participants