WorkflowTesting changes to support GUWT #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencochran
reviewed
Jun 26, 2020
dhavalshreyas
force-pushed
the
dhaval/workflowTestingChanges
branch
from
e02926f to
03c421b
Compare
dhavalshreyas
force-pushed
the
dhaval/workflowTestingChanges
branch
from
03c421b to
7539563
Compare
AquaGeek
reviewed
Jun 29, 2020
| let rendering: Any | ||
| let output: Any? | ||
| let doesMatch: (_ childWorkflow: Any, _ childKey: String) -> Bool |
There was a problem hiding this comment.
This sounds strange to me. Can we call this matches instead?
There was a problem hiding this comment.
Closing this one, in favor of #15
|
Closing this one in favor of #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
SignalProducerWorkerwill use aSignalProducerWorkerWorkflowto runSignalProducer.To be able to build
ExpectedSignalProducerWorker,ExpectedWorkflowwill need to support custom matching (b/w the expected and the actualWorkflow) and assertions.Changes in this PR will enable this.