Revert "Introduce support for ViewTreeSavedStateRegistryOwner in Android container views." #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid container views." This reverts commit 31f758d. We noticed a bunch of tests failing internally, so clearly this repo is missing some tests.
rjrjr
approved these changes
Mar 5, 2021
|
Lol, this also reverts the CI timeout and now the shards are timing out again. I am surprised – with the tests reverted, I don't know why they would take so long still. Plus, the emulator action recently started using 2 cores instead of 1 for the emulators, which should reduce times not increase them. Anyway, I'm pretty confident this doesn't actually break anything, we just might need to re-configure CI again after landing this. I'm going to go ahead and merge without babysitting CI for another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 31f758d.
We noticed a bunch of tests failing internally, so clearly this repo is missing some tests.