Migrate Parametrized Tests to Burst #1354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/dea-2
branch
3 times, most recently
from
e283c6f to
2b31b09
Compare
steve-the-edwards
force-pushed
the
sedwards/compose-dispatcher
branch
from
3276377 to
229688b
Compare
steve-the-edwards
force-pushed
the
sedwards/dea-2
branch
from
2b31b09 to
c56778c
Compare
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
steve-the-edwards
force-pushed
the
sedwards/dea-2
branch
from
c56778c to
f116b2d
Compare
zach-klippenstein
approved these changes
Jun 23, 2025
|
|
||
| private val runtimeTestRunner = | ||
| ParameterizedTestRunner<Triple<RuntimeConfig, WorkflowTracer?, TestDispatcher>>() | ||
| private fun advanceIfStandard(dispatcher: TestDispatcher) { |
There was a problem hiding this comment.
It looks like the only thing you ever pass here is dispatcherUsed, so don't need the parameter. I believe the only result of passing in a different value would be that it would make the test incorrect, so why allow the foot gun?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start using Burst anywhere we parametrize tests. This will help prep for adding new runtime configs in one place.