Skip to content

Ensure unit test coverage for awaitFailure and exception thrown from render method #60

Open
@kirillzh

Description

@kirillzh

Consider this simple stateful workflow that throws TODO() on render.

class FooWorkflow : StatefulWorkflow<Unit, State, Unit, Unit>() {

  override fun initialState(
    props: Unit,
    snapshot: Snapshot?
  ): State = State

  override fun render(
    props: Unit,
    state: State,
    context: RenderContext<State, Unit>
  ) {
    TODO("implement me")
  }

  override fun snapshotState(state: State): Snapshot = Snapshot.EMPTY

  object State
}

This is what my unit test looks like to test that the workflow indeed throws (realistically I wanted to throw in a very certain, not yet implemented case and I added a unit test for that ala TDD):

class FooWorkflowTest {
  private val fooWorkflow = FooWorkflow()

  @Test
  fun verifyThrowsException() {
    fooWorkflow.testFromStart {
      assertThat(awaitFailure()).isInstanceOf<NotImplementedError>()
    }
  }
}

While test passes, it still throws right after that:

Exception in thread "main @coroutine#3" kotlin.NotImplementedError: An operation is not implemented: implement
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:20)
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:8)
	at com.squareup.workflow.internal.WorkflowNode.renderWithStateType(WorkflowNode.kt:178)
	at com.squareup.workflow.internal.WorkflowNode.render(WorkflowNode.kt:95)
	at com.squareup.workflow.internal.RealWorkflowLoop$runWorkflowLoop$2.invokeSuspend(WorkflowLoop.kt:79)
	(Coroutine boundary)
	at com.squareup.workflow.LaunchWorkflowKt$launchWorkflowImpl$workflowJob$1.invokeSuspend(LaunchWorkflow.kt:174)
Caused by: kotlin.NotImplementedError: An operation is not implemented: implement
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:20)
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:8)
	at com.squareup.workflow.internal.WorkflowNode.renderWithStateType(WorkflowNode.kt:178)
	at com.squareup.workflow.internal.WorkflowNode.render(WorkflowNode.kt:95)
	at com.squareup.workflow.internal.RealWorkflowLoop$runWorkflowLoop$2.invokeSuspend(WorkflowLoop.kt:79)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:241)
	at kotlinx.coroutines.EventLoop.processUnconfinedEvent(EventLoop.common.kt:68)
	at kotlinx.coroutines.DispatchedKt.resumeCancellable(Dispatched.kt:464)
	at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:26)
	at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:109)
	at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:154)
	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:54)
	at kotlinx.coroutines.BuildersKt.launch(Unknown Source)
	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch$default(Builders.common.kt:47)
	at kotlinx.coroutines.BuildersKt.launch$default(Unknown Source)
	at com.squareup.workflow.LaunchWorkflowKt.launchWorkflowImpl(LaunchWorkflow.kt:166)
	at com.squareup.workflow.LaunchWorkflowKt.launchWorkflowIn(LaunchWorkflow.kt:109)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart(WorkflowTester.kt:230)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart(WorkflowTester.kt:253)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart$default(WorkflowTester.kt:251)
	at com.squareup.scales.FooWorkflowTest.verifyThrowsException(FooWorkflowTest.kt:13)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:305)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:365)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:330)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:78)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:328)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:65)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:292)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:305)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:412)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:66)
Exception in thread "main @coroutine#1" kotlin.NotImplementedError: An operation is not implemented: implement
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:20)
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:8)
	at com.squareup.workflow.internal.WorkflowNode.renderWithStateType(WorkflowNode.kt:178)
	at com.squareup.workflow.internal.WorkflowNode.render(WorkflowNode.kt:95)
	at com.squareup.workflow.internal.RealWorkflowLoop$runWorkflowLoop$2.invokeSuspend(WorkflowLoop.kt:79)
	(Coroutine boundary)
	at com.squareup.workflow.LaunchWorkflowKt$launchWorkflowImpl$workflowJob$1.invokeSuspend(LaunchWorkflow.kt:174)
Caused by: kotlin.NotImplementedError: An operation is not implemented: implement
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:20)
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:8)
	at com.squareup.workflow.internal.WorkflowNode.renderWithStateType(WorkflowNode.kt:178)
	at com.squareup.workflow.internal.WorkflowNode.render(WorkflowNode.kt:95)
	at com.squareup.workflow.internal.RealWorkflowLoop$runWorkflowLoop$2.invokeSuspend(WorkflowLoop.kt:79)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:241)
	at kotlinx.coroutines.EventLoop.processUnconfinedEvent(EventLoop.common.kt:68)
	at kotlinx.coroutines.DispatchedKt.resumeCancellable(Dispatched.kt:464)
	at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:26)
	at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:109)
	at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:154)
	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:54)
	at kotlinx.coroutines.BuildersKt.launch(Unknown Source)
	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch$default(Builders.common.kt:47)
	at kotlinx.coroutines.BuildersKt.launch$default(Unknown Source)
	at com.squareup.workflow.LaunchWorkflowKt.launchWorkflowImpl(LaunchWorkflow.kt:166)
	at com.squareup.workflow.LaunchWorkflowKt.launchWorkflowIn(LaunchWorkflow.kt:109)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart(WorkflowTester.kt:230)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart(WorkflowTester.kt:253)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart$default(WorkflowTester.kt:251)
	at com.squareup.scales.FooWorkflowTest.verifyThrowsException(FooWorkflowTest.kt:13)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:305)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:365)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:330)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:78)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:328)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:65)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:292)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:305)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:412)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:66)
Exception in thread "main @coroutine#2" kotlin.NotImplementedError: An operation is not implemented: implement
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:20)
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:8)
	at com.squareup.workflow.internal.WorkflowNode.renderWithStateType(WorkflowNode.kt:178)
	at com.squareup.workflow.internal.WorkflowNode.render(WorkflowNode.kt:95)
	at com.squareup.workflow.internal.RealWorkflowLoop$runWorkflowLoop$2.invokeSuspend(WorkflowLoop.kt:79)
	(Coroutine boundary)
	at com.squareup.workflow.LaunchWorkflowKt$launchWorkflowImpl$workflowJob$1.invokeSuspend(LaunchWorkflow.kt:174)
Caused by: kotlin.NotImplementedError: An operation is not implemented: implement
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:20)
	at com.squareup.scales.FooWorkflow.render(FooWorkflow.kt:8)
	at com.squareup.workflow.internal.WorkflowNode.renderWithStateType(WorkflowNode.kt:178)
	at com.squareup.workflow.internal.WorkflowNode.render(WorkflowNode.kt:95)
	at com.squareup.workflow.internal.RealWorkflowLoop$runWorkflowLoop$2.invokeSuspend(WorkflowLoop.kt:79)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:241)
	at kotlinx.coroutines.EventLoop.processUnconfinedEvent(EventLoop.common.kt:68)
	at kotlinx.coroutines.DispatchedKt.resumeCancellable(Dispatched.kt:464)
	at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:26)
	at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:109)
	at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:154)
	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:54)
	at kotlinx.coroutines.BuildersKt.launch(Unknown Source)
	at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch$default(Builders.common.kt:47)
	at kotlinx.coroutines.BuildersKt.launch$default(Unknown Source)
	at com.squareup.workflow.LaunchWorkflowKt.launchWorkflowImpl(LaunchWorkflow.kt:166)
	at com.squareup.workflow.LaunchWorkflowKt.launchWorkflowIn(LaunchWorkflow.kt:109)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart(WorkflowTester.kt:230)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart(WorkflowTester.kt:253)
	at com.squareup.workflow.testing.WorkflowTesterKt.testFromStart$default(WorkflowTester.kt:251)
	at com.squareup.scales.FooWorkflowTest.verifyThrowsException(FooWorkflowTest.kt:13)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:305)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:365)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:330)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:78)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:328)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:65)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:292)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:305)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:412)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:66)

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions