Clarify the fixup instructions for the precommit hook. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @orta |
| # This is what the dev can run to fixup an individual file | ||
| echo "\"$DIR\"/format-objc-file.sh '$file' && git add '$file';" | ||
| echo -e "\"$DIR\"/format-objc-file.sh '$file' && git add '$file';" |
There was a problem hiding this comment.
NIT: I don't think you need the -e here, because there is no \n on the line.
There was a problem hiding this comment.
With the below "fix all" message, it seems reasonable to remove the git add here, which would also address @orta's issue.
|
LGTM |
|
LGTM as well. |
alanf
force-pushed
the
alanf/clearer-instructions
branch
from
99c9061 to
14d726e
Compare
alanf
added a commit
that referenced
this pull request
Oct 27, 2015
Clarify the fixup instructions for the precommit hook.
|
Ace! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the people know that there's a fast way to fix and stage changes!