Fix FileHandle thread safety on native platforms#1780
Open
MohammadKHC wants to merge 5 commits intosquare:masterfrom
Open
Fix FileHandle thread safety on native platforms#1780MohammadKHC wants to merge 5 commits intosquare:masterfrom
FileHandle thread safety on native platforms#1780MohammadKHC wants to merge 5 commits intosquare:masterfrom
Conversation
Contributor
Author
|
Or should we just implement the I think that Atomics should be more efficient for this use case. |
JakeWharton
reviewed
Feb 12, 2026
Contributor
Author
|
@JakeWharton Okay! instead of using atomics, Can you review it again? |
JakeWharton
reviewed
Feb 19, 2026
Replace no-op Lock with AtomicBoolean/AtomicInt for proper synchronization.
MohammadKHC
force-pushed
the
fix-filehandle
branch
from
8eaa3e8 to
d2b9a9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace no-op Lock with
AtomicBoolean/AtomicIntfor proper synchronization.Is it fine to delete
newLock()completely?Lockis public butnewLock()is internal, andFileHandlewas the only place using it.Closes #1778