Skip to content

Recover from an SSLSocket crash #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

Recover from an SSLSocket crash #1714

merged 2 commits into from
Oct 9, 2025
+14 −2

Conversation

@swankjesse
Copy link
Collaborator

@swankjesse swankjesse commented Oct 9, 2025

@swankjesse swankjesse requested a review from yschimke October 9, 2025 21:32
@swankjesse
Copy link
Collaborator Author

swankjesse commented Oct 9, 2025

FYI @yschimke I changed it to use InputStream.close() / OutputStream.close() instead. These bottom out in the same code but I think closing the stream is more semantic.

@swankjesse swankjesse enabled auto-merge (squash) October 9, 2025 21:42
@swankjesse swankjesse disabled auto-merge October 9, 2025 21:44
@swankjesse swankjesse merged commit 3df8719 into master Oct 9, 2025
12 checks passed
@swankjesse swankjesse deleted the jwilson.1009.recover branch October 9, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swankjesse @yschimke @squarejesse