Skip to content

Fix RouteFailureTest and use RepeatedTest #9247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yschimke merged 1 commit into from
Jan 10, 2026
Merged

Fix RouteFailureTest and use RepeatedTest #9247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions okhttp/src/jvmTest/kotlin/okhttp3/RouteFailureTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import okhttp3.internal.http.RecordingProxySelector
import okhttp3.internal.http2.ErrorCode
import okhttp3.testing.PlatformRule
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.RepeatedTest
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.extension.RegisterExtension

Expand Down Expand Up @@ -82,7 +83,7 @@ class RouteFailureTest {
.build()
}

@Test
@RepeatedTest(100)
fun http2OneBadHostOneGoodNoRetryOnConnectionFailure() {
enableProtocol(Protocol.HTTP_2)

Expand All @@ -107,6 +108,7 @@ class RouteFailureTest {
.assertFailureMatches("stream was reset: REFUSED_STREAM")

assertThat(client.routeDatabase.failedRoutes).isEmpty()
server1.takeRequest()
assertThat(server1.requestCount).isEqualTo(1)
assertThat(server2.requestCount).isEqualTo(0)

Expand Down Expand Up @@ -162,7 +164,7 @@ class RouteFailureTest {
)
}

@Test
@RepeatedTest(100)
fun http2OneBadHostOneGoodNoRetryOnConnectionFailureFastFallback() {
enableProtocol(Protocol.HTTP_2)

Expand All @@ -187,6 +189,7 @@ class RouteFailureTest {
.assertFailureMatches("stream was reset: REFUSED_STREAM")

assertThat(client.routeDatabase.failedRoutes).isEmpty()
server1.takeRequest()
assertThat(server1.requestCount).isEqualTo(1)
assertThat(server2.requestCount).isEqualTo(0)

Expand Down Expand Up @@ -242,7 +245,7 @@ class RouteFailureTest {
)
}

@Test
@RepeatedTest(100)
fun http2OneBadHostRetryOnConnectionFailure() {
enableProtocol(Protocol.HTTP_2)

Expand All @@ -266,6 +269,7 @@ class RouteFailureTest {
.assertFailureMatches("stream was reset: REFUSED_STREAM")

assertThat(client.routeDatabase.failedRoutes).isEmpty()
server1.takeRequest()
assertThat(server1.requestCount).isEqualTo(1)

assertThat(clientTestRule.recordedConnectionEventTypes()).containsExactly(
Expand All @@ -276,7 +280,7 @@ class RouteFailureTest {
)
}

@Test
@RepeatedTest(100)
fun http2OneBadHostRetryOnConnectionFailureFastFallback() {
enableProtocol(Protocol.HTTP_2)

Expand All @@ -300,6 +304,7 @@ class RouteFailureTest {
.assertFailureMatches("stream was reset: REFUSED_STREAM")

assertThat(client.routeDatabase.failedRoutes).isEmpty()
server1.takeRequest()
assertThat(server1.requestCount).isEqualTo(1)

assertThat(clientTestRule.recordedConnectionEventTypes()).containsExactly(
Expand Down
Loading