Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify kts #6961

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Simplify kts #6961

merged 1 commit into from
Dec 17, 2021

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Dec 16, 2021

Follow up PR for #6959, to use extensions and replace deprecated BundleTaskConvention.

/**
 * BundleTaskConvention for Gradle.
 *
 * @deprecated Replaced by BundleTaskExtension.
 */
@Deprecated
public class BundleTaskConvention

copy the constructor from

private static BundleTaskExtension getBundleTaskExtension(org.gradle.api.tasks.bundling.Jar task) {
    BundleTaskExtension extension = task.getExtensions()
	.findByType(BundleTaskExtension.class);
    if (extension != null) {
	return extension;
    }
    return task.getExtensions()
	.create(BundleTaskExtension.NAME, BundleTaskExtension.class, task);
}

@yschimke yschimke merged commit 2dbb9c2 into square:master Dec 17, 2021
@Goooler Goooler deleted the kts branch December 17, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants