Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Proguard Rules #6792

Merged
merged 5 commits into from
Nov 14, 2021
Merged

Extend Proguard Rules #6792

merged 5 commits into from
Nov 14, 2021

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jul 29, 2021 •
edited
Loading

TODO show cleanup of proguard warnings

@yschimke yschimke added the android Relates to usage specifically on Android label Jul 29, 2021
bekuno added a commit to bekuno/cgeo that referenced this pull request Aug 29, 2021
@bekuno
add proguard rules related to OkHttp
929777e 
Fix R8 missing class warnings, probaly fixed in next OkHttp release,
see square/okhttp#6792
@bekuno bekuno mentioned this pull request Aug 29, 2021
Merged
bekuno added a commit to cgeo/cgeo that referenced this pull request Sep 8, 2021
@bekuno
add proguard rules related to OkHttp (#11581)
e0a3544 
* add proguard rule related to OkHttp

Fix R8 missing class warnings, probaly fixed in next OkHttp release,
see square/okhttp#6792
@yschimke yschimke marked this pull request as ready for review October 29, 2021 09:27
@yschimke
Copy link
Collaborator Author

ping @swankjesse tested this on a separate project.

@G00fY2
Copy link
Contributor

G00fY2 commented Nov 10, 2021

I support this PR. We currently see these warnings in our production builds (AGP 7.0.3/OkHttp 4.9.2):

> Task :app:minifyProductionStoreReleaseWithR8
WARNING:Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /bitrise/src/app/build/outputs/mapping/productionStoreRelease/missing_rules.txt.
WARNING:R8: Missing class org.bouncycastle.jsse.BCSSLParameters (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 1 other context)
Missing class org.bouncycastle.jsse.BCSSLSocket (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 5 other contexts)
Missing class org.bouncycastle.jsse.provider.BouncyCastleJsseProvider (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.<init>())
Missing class org.conscrypt.Conscrypt$Version (referenced from: boolean okhttp3.internal.platform.ConscryptPlatform$Companion.atLeastVersion(int, int, int))
Missing class org.conscrypt.Conscrypt (referenced from: boolean okhttp3.internal.platform.ConscryptPlatform$Companion.atLeastVersion(int, int, int) and 4 other contexts)
Missing class org.conscrypt.ConscryptHostnameVerifier (referenced from: okhttp3.internal.platform.ConscryptPlatform$DisabledHostnameVerifier)
Missing class org.openjsse.javax.net.ssl.SSLParameters (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List))
Missing class org.openjsse.javax.net.ssl.SSLSocket (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 1 other context)
Missing class org.openjsse.net.ssl.OpenJSSE (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.<init>())

@yschimke
Copy link
Collaborator Author

Failures are only the tests fixed in https://github.com/square/okhttp/pull/6892/files

@yschimke
Copy link
Collaborator Author

@swankjesse request post review

@yschimke yschimke merged commit 9da841c into square:master Nov 14, 2021
swankjesse
swankjesse reviewed Nov 20, 2021
View reviewed changes
Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yschimke yschimke mentioned this pull request Nov 24, 2021
Closed
@yschimke yschimke deleted the proguard branch January 6, 2022 08:42
Goooler
Goooler reviewed Oct 9, 2022
View reviewed changes
Copy link
Contributor

@Goooler Goooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we should pick up this change to 4.10.x branch? Cause I see the build failures on AGP 8.0.0-alpha02 & Okhttp 4.10.0, see Goooler/DemoApp#220 (comment).

yschimke added a commit to yschimke/okhttp that referenced this pull request Oct 9, 2022
@yschimke
Extend Proguard Rules (square#6792)
5214beb 
(cherry picked from commit 9da841c)
@yschimke
Copy link
Collaborator Author

yschimke commented Oct 9, 2022

Fix here https://github.com/square/okhttp/pull/7471/files

yschimke added a commit that referenced this pull request Oct 10, 2022
@yschimke
Extend Proguard Rules (#6792) (#7471)
cf088f8 
(cherry picked from commit 9da841c)
@martinbonnin martinbonnin mentioned this pull request May 22, 2023
Merged
adgeg added a commit to SocialGouv/pass_emploi_app that referenced this pull request Mar 27, 2024
@adgeg
build: Fix R8 issues on okhttp
46463f3 
square/okhttp#6792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goooler Goooler Goooler left review comments

@swankjesse swankjesse swankjesse left review comments

Assignees
No one assigned
Labels
android Relates to usage specifically on Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yschimke @G00fY2 @swankjesse @Goooler