BufferedSource. #524
Merged
BufferedSource. #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Source API is nice for source implementors: no annoying skip method, no annoying available() method, just one API to supply bytes to the caller. But it isn't as nice of an API for source callers. It lacks convenient APIs! This bridges the gap. Calling code should use BufferedSource, and implementing code should implement Source.
|
test fail seems to only be occurring from travis. I've checked out the branch locally and it passes fine. |
|
good idea, @swankjesse! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Source API is nice for source implementors: no annoying
skip method, no annoying available() method, just one API to
supply bytes to the caller.
But it isn't as nice of an API for source callers. It lacks
convenient APIs!
This bridges the gap. Calling code should use BufferedSource,
and implementing code should implement Source.