Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OkBuffer in http/2 source stream #523

Merged
merged 1 commit into from
Feb 11, 2014
Merged

Use OkBuffer in http/2 source stream #523

merged 1 commit into from
Feb 11, 2014

Conversation

swankjesse
Copy link
Collaborator

No description provided.

codefromthecrypt
codefromthecrypt reviewed Feb 11, 2014
View reviewed changes
okhttp-protocols/src/main/java/com/squareup/okhttp/internal/spdy/FrameReader.java
* @param errorCode reason for closing the connection.
* @param debugData only valid for http/2; opaque debug data to send.
*/
void goAway(int lastGoodStreamId, ErrorCode errorCode, byte[] debugData);
void goAway(int lastGoodStreamId, ErrorCode errorCode, ByteString debugData);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@codefromthecrypt
Copy link

There are a couple of these in the build log.. maybe just fluff, but worth looking at.

Exception in thread "Thread-127" java.lang.NullPointerException
    at com.squareup.okhttp.internal.bytes.OkBuffers$4.read(OkBuffers.java:217)
    at com.squareup.okhttp.internal.Util.skipByReading(Util.java:284)
    at com.squareup.okhttp.internal.Util.skipByReading(Util.java:300)
    at com.squareup.okhttp.internal.spdy.SpdyConnection$Reader.data(SpdyConnection.java:539)
    at com.squareup.okhttp.internal.spdy.Http20Draft09$Reader.readData(Http20Draft09.java:191)
    at com.squareup.okhttp.internal.spdy.Http20Draft09$Reader.nextFrame(Http20Draft09.java:113)
    at com.squareup.okhttp.internal.spdy.SpdyConnection$Reader.execute(SpdyConnection.java:519)
    at com.squareup.okhttp.internal.NamedRunnable.run(NamedRunnable.java:33)
    at java.lang.Thread.run(Thread.java:744)

@codefromthecrypt
Copy link

Thanks for the help! LG after the NPE chase (which might be unrelated).

@swankjesse
Copy link
Collaborator Author

NPE problem was in the code before, but it's exacerbated by this bug. We were using multiple threads to read the connection header in MockWebServer.

swankjesse added a commit that referenced this pull request Feb 11, 2014
@swankjesse
Merge pull request #523 from square/jwilson_0211_okbuffer_in_http2_so…
545807e 
…urce

Use OkBuffer in http/2 source stream
@swankjesse swankjesse merged commit 545807e into master Feb 11, 2014
@codefromthecrypt
Copy link

Thanks for checking. Not surprised it was latent.. sorry about that!

@swankjesse swankjesse deleted the jwilson_0211_okbuffer_in_http2_source branch February 14, 2014 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swankjesse @codefromthecrypt @squarejesse