Use OkBuffer in spdy/3 source stream. #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,7 +102,7 @@ | |||
| } | |||
|
|
|||
| @Override public FrameReader newReader(InputStream in, boolean client) { | |||
| return new Reader(in, client); | |||
| return new Reader(OkBuffers.source(in), client); | |||
There was a problem hiding this comment.
This is an adapter on the way in.
|
LG only editorial comments. tested via ExternalSpdyExample |
|
also tested with okcurl ~/Development/okhttp/okcurl jwilson_0209_okbuffer_in_spdy3_source ./target/okcurl-2.0.0-SNAPSHOT-jar-with-dependencies.jar -p spdy/3 -i https://google.ca
HTTP/1.1 301 Moved Permanently
OkHttp-Selected-Transport: spdy/3.1
OkHttp-Selected-Protocol: spdy/3.1
alternate-protocol: 443:quic
cache-control: public, max-age=2592000
content-length: 219
content-type: text/html; charset=UTF-8
date: Tue, 11 Feb 2014 16:49:04 GMT
expires: Thu, 13 Mar 2014 16:49:04 GMT
location: https://www.google.ca/
server: gws
x-frame-options: SAMEORIGIN
x-xss-protection: 1; mode=block
OkHttp-Sent-Millis: 1392137345635
OkHttp-Received-Millis: 1392137345749
OkHttp-Response-Source: NETWORK 301
<HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
<TITLE>301 Moved</TITLE></HEAD><BODY>
<H1>301 Moved</H1>
The document has moved
<A HREF="https://www.google.ca/">here</A>.
</BODY></HTML> |
This isn't quite as simple as I had hoped. We still lack something like DataInputStream/BufferedInputStream that combines a buffer with a Source. That means there's a bunch of methods that must manually refill the buffer before acting upon it. I'm going to continue to migrate code, and will follow up with changes to simplify this interaction.
swankjesse
added a commit
that referenced
this pull request
Feb 11, 2014
…urce Use OkBuffer in spdy/3 source stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't quite as simple as I had hoped. We still lack something
like DataInputStream/BufferedInputStream that combines a buffer with
a Source. That means there's a bunch of methods that must manually
refill the buffer before acting upon it.
I'm going to continue to migrate code, and will follow up with
changes to simplify this interaction.