Fix some OkBuffer bugs. #517
Merged
+72
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GzipSource exceptions used six hex digits instead of 8 to print ints. readUtf8 always did an extra copy of the bytes being read. Moving bytes between buffers crashed when the destination was empty and the source was a prefix. InputStream reading returned values in -128..127 instead of in 0..255.
|
thanks! |
codefromthecrypt
pushed a commit
that referenced
this pull request
Feb 8, 2014
Fix some OkBuffer bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GzipSource exceptions used six hex digits instead of
8 to print ints.
readUtf8 always did an extra copy of the bytes being
read.
Moving bytes between buffers crashed when the destination
was empty and the source was a prefix.
InputStream reading returned values in -128..127 instead
of in 0..255.