Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename byteAt to getByte. #516

Merged
merged 1 commit into from
Feb 8, 2014

Conversation

swankjesse
Copy link
Collaborator

Should we later support random access for other primitives
or random bulk access, I'd like the prefix to stay constant
(getByte, getInt, getLong, getBytes) vs. the suffix (byteAt,
intAt, longAt). Prefixing may work better for autocomplete
in IDEs, particularly since we already use a prefix for our
consuming reads (readByte, readInt, readLong).

Should we later support random access for other primitives
or random bulk access, I'd like the prefix to stay constant
(getByte, getInt, getLong, getBytes) vs. the suffix (byteAt,
intAt, longAt). Prefixing may work better for autocomplete
in IDEs, particularly since we already use a prefix for our
consuming reads (readByte, readInt, readLong).
@codefromthecrypt
Copy link

sounds good.

codefromthecrypt pushed a commit that referenced this pull request Feb 8, 2014
@codefromthecrypt codefromthecrypt merged commit 4c8ce7c into master Feb 8, 2014
@codefromthecrypt codefromthecrypt deleted the jwilson_0208_byte_at_to_get_byte branch February 8, 2014 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants