New benchmark target for Netty. #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required some reworking to the harness since Netty doesn't want to be used with an ExecutorService. NettyHttpClient [HTTP_11] bodyByteCount=1048576 headerCount=20 concurrencyLevel=10 Requests per second: 597.1 OkHttp [HTTP_11] bodyByteCount=1048576 headerCount=20 concurrencyLevel=10 Requests per second: 705.2
|
Related: netty/netty#2176 |
| } | ||
|
|
||
| pipeline.addLast("codec", new HttpClientCodec()); | ||
| pipeline.addLast("inflater", new HttpContentDecompressor()); |
There was a problem hiding this comment.
To be "realistic" I want the client to use the full pipeline even in scenarios where there's no decompression.
|
LG |
|
@swankjesse well in netty 5.x (current master) you can pass an |
|
@normanmaurer good to know. Most of this change is necessary to support async. |
swankjesse
added a commit
that referenced
this pull request
Feb 1, 2014
New benchmark target for Netty.
|
@swankjesse np... feel free to ping me if you need more infos. Or ask @adriancole how to contact me he has all the details ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required some reworking to the harness since Netty doesn't
want to be used with an ExecutorService.
NettyHttpClient [HTTP_11]
bodyByteCount=1048576 headerCount=20 concurrencyLevel=10
Requests per second: 597.1
OkHttp [HTTP_11]
bodyByteCount=1048576 headerCount=20 concurrencyLevel=10
Requests per second: 705.2