Adapters that go the other way, to java.io. #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These ones are slightly more awkward because they need to do their own internal buffering.
|
Agreed the impl is more awkward than other code, but justifiably. Each time I thought "maybe this part of the imple of read or write should be commented," I turned around and realized it is easier to explain in java and tests! I looked for obvious and subtle problems, but couldn't spot any. Good job and I plan to use this. LGTM! |
swankjesse
added a commit
that referenced
this pull request
Jan 31, 2014
Adapters that go the other way, to java.io.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These ones are slightly more awkward because they need to do
their own internal buffering.