Send window update after the peer sends half the limit on a stream or connection #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| int initialWindowSize = 65535; | ||
| // Visible for testing | ||
| long bytesLeftBeforeReadAck; |
There was a problem hiding this comment.
I think I prefer the way the SpdyStream class tracks the inverse of this, unacknowledgedBytes. My issue with bytesLeftBeforeReadAck is that it suggests a single hard deadline (0) but for maximum throughput we should ack earlier than necessary.
|
One missing synchronized block. Is it safe to grab the connection lock while holding the stream lock? I'm hoping it is. |
|
grabbed a connection lock, outside the stream lock. should be good to go! |
| * account max frame size per variant. | ||
| */ | ||
| @Test @Ignore public void readSendsWindowUpdateHttp2() throws Exception { | ||
| @Test public void readSendsWindowUpdateHttp2() throws Exception { |
swankjesse
added a commit
that referenced
this pull request
Jan 27, 2014
Send window update after the peer sends half the limit on a stream or connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final change for connection-level flow control in spdy or http/2.