Add get(String) alternative which fails on invalid inputs #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Jul 6, 2018
| throws MalformedURLException, UnknownHostException { | ||
| return HttpUrl.getChecked(url); | ||
| @Override public boolean isInvalidHttpUrlHost(IllegalArgumentException e) { | ||
| return e.getMessage().startsWith(HttpUrl.Builder.INVALID_HOST); |
There was a problem hiding this comment.
So yeah this is kinda gross, but... whatever. It's only for HttpURLConnection use.
swankjesse
approved these changes
Jul 6, 2018
| assertEquals(parse("https://host/"), parse("https://host/")); | ||
| assertEquals(parse("https://host/"), parse("HTTPS://host/")); | ||
|
|
||
| assertInvalid("image640://480.png", "Expected URL scheme 'http' or 'https' but was 'image640'"); |
JakeWharton
force-pushed
the
jakew/parseOrThrow/2018-07-05
branch
from
9be52c7 to
75a467b
Compare
This is an unchecked-throwing version of parse(String).
JakeWharton
force-pushed
the
jakew/parseOrThrow/2018-07-05
branch
from
75a467b to
351b3d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unchecked-throwing version of parse(String).
Closes #3850. Closes #4032.