Use Request and Response types in OkResponseCache. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,7 +237,8 @@ public Builder addHeader(String name, String value) { | |||
| return this; | |||
| } | |||
|
|
|||
| Builder rawHeaders(RawHeaders rawHeaders) { | |||
| // TODO: this shouldn't be public. | |||
There was a problem hiding this comment.
This is the trickiest part of this change. I think I'll be able to fix this in a follow-up by using Request + Response more internally in HttpEngine. The tricky part of that change is that Request + Response are immutable, but the classes in use now (RequestHeaders, ResponseHeaders) are mutable.
|
I support this change and agree with the rationale. |
| ? entry.handshake.localCertificates() | ||
| : null; | ||
| @Override public long contentLength() { | ||
| return contentLength != null ? Long.parseLong(contentLength) : -1; |
There was a problem hiding this comment.
This still has the potential to throw on a malformed header, right? The response is persisted to the cache as-is.
There was a problem hiding this comment.
Yup, good catch. Fixed to try/catch and return -1. In follow up I'll try to find a way to share the ResponseHeaders parser here.
This breaks support for java.net.ResponseCache implementations. That's good. That API is akward and can't support important features like conditional GETs and hit tracking.
JakeWharton
added a commit
that referenced
this pull request
Dec 30, 2013
Use Request and Response types in OkResponseCache.
|
Lots of good red code in this diff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks support for java.net.ResponseCache implementations. That's
good. That API is akward and can't support important features like
conditional GETs and hit tracking.