Fix some Autobahn tests. #2996
Merged
Fix some Autobahn tests. #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the queue limit to 16 MiB for Autobahn tests. This is the ceiling they use and necessary to pass their tests. Move to port 9099. Port 9001 conflicts with supervisord. Throw the right exceptions on close codes, at the right times.
swankjesse
commented
Nov 21, 2016
| @@ -103,21 +103,21 @@ static void toggleMask(byte[] buffer, long byteCount, byte[] key, long frameByte | |||
| } | |||
| } | |||
|
|
|||
| static void validateCloseCode(int code, boolean argument) throws ProtocolException { | |||
There was a problem hiding this comment.
this was awkward because it was throwing a checked exception
JakeWharton
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the queue limit to 16 MiB for Autobahn tests. This is the ceiling they
use and necessary to pass their tests.
Move to port 9099. Port 9001 conflicts with supervisord.
Throw the right exceptions on close codes, at the right times.