Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HttpUrl internally. #1784

Merged
merged 1 commit into from
Aug 3, 2015
Merged

Use HttpUrl internally. #1784

merged 1 commit into from
Aug 3, 2015
+109 −161

Conversation

swankjesse
Copy link
Collaborator

Closes #1044

JakeWharton
JakeWharton reviewed Aug 3, 2015
View reviewed changes
okhttp/src/main/java/com/squareup/okhttp/internal/http/HttpEngine.java

// Don't follow redirects to unsupported protocols.
if (!url.getProtocol().equals("https") && !url.getProtocol().equals("http")) return null;
if (url == null) return null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

JakeWharton added a commit that referenced this pull request Aug 3, 2015
@JakeWharton
Merge pull request #1784 from square/jwilson_0802_use_httpurl_internally
7cf6363 
Use HttpUrl internally.
@JakeWharton JakeWharton merged commit 7cf6363 into master Aug 3, 2015
@JakeWharton
Copy link
Collaborator

Lovely

@JakeWharton JakeWharton deleted the jwilson_0802_use_httpurl_internally branch August 3, 2015 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swankjesse @JakeWharton @squarejesse