Expose internal APIs for pluggable file systems. #1781
Merged
+77
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aren't yet ready to make FileSystem a public type, but I don't mind making it _almost_ available via an internal API for those brave enough to try that. Also migrate all of our tests to use the in memory file system. It's simpler. #1459
| this(directory, maxSize, FileSystem.SYSTEM); | ||
| } | ||
|
|
||
| Cache(File directory, long maxSize, FileSystem fileSystem) { |
There was a problem hiding this comment.
This is the new seam that allows daring application developers to plug in their own file system wrappers.
There was a problem hiding this comment.
internal-only, but if it proves useful we can make it public later (possibly in okio).
JakeWharton
added a commit
that referenced
this pull request
Aug 1, 2015
Expose internal APIs for pluggable file systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't yet ready to make FileSystem a public type, but I don't mind
making it almost available via an internal API for those brave enough
to try that.
Also migrate all of our tests to use the in memory file system. It's simpler.
#1459