make the DiskLruCache's initialize() public through the Cache interface #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,7 +198,7 @@ public void run() { | |||
| } | |||
|
|
|||
| // Visible for testing. | |||
There was a problem hiding this comment.
This comment is no longer necessary.
|
Works for me. One small comment, and also please use http://rebaseandsqua.sh. |
|
CLA is good! |
make the DiskLruCache's initialize() public through the Cache interface The DiskLruCache’s cache does lazy initialization. The time spent in initialization varies depending on the actual cache size and journal file size. On very low end device, the initialization time could be as long as 1000 ms once the cache reaches 100M for example on a 4.0 device. This has significant performance impact on the very 1st cache hit. So the proposed solution is to give the developer an opportunity to explicitly do the initialization early on and in a back ground thread. Without this change, the developer would have to call any method from the Cache class to warm up the cache implicitly.
halizton
force-pushed
the
make_cache_init_public
branch
from
ff4c583
to
6e6c3e9
Compare
|
Thanks, swankjesse, I used rebaseandsqua.sh to squash the 3 commits into one. What's CLA by the way? |
swankjesse
added a commit
that referenced
this pull request
Jul 22, 2015
make the DiskLruCache's initialize() public through the Cache interface
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DiskLruCache’s cache does lazy initialization. The time spent in
initialization varies depending on the actual cache size and journal
file size.
On very low end device, the initialization time could be as long as
1000 ms once the cache reaches 100M for example on a 4.0 device. This
has significant performance impact on the very 1st cache hit.
So the proposed solution is to give the developer an opportunity to
explicitly do the initialization early on and in a back ground thread.
Without this change, the developer would have to call any method from
the Cache class to warm up the cache implicitly.