Fix FormEncodingBuilder to be consistent with browsers. #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we're using the same encode set as the URL query; that's a mistake.
| @@ -256,10 +256,11 @@ | |||
| private static final char[] HEX_DIGITS = | |||
| { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F' }; | |||
| static final String USERNAME_ENCODE_SET = " \"':;<=>@[]^`{}|/\\?#"; | |||
| static final String PASSWORD_ENCODE_SET = " \"':;<=>@[]\\^`{}|/\\?#"; | |||
There was a problem hiding this comment.
The \\ was duplicated!
JakeWharton
added a commit
that referenced
this pull request
Jun 21, 2015
Fix FormEncodingBuilder to be consistent with browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're using the same encode set as the URL query; that's a mistake.