Revert Call to a protected class instead of package-private #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought it was package-protected by default. |
|
Sanity checking myself, but Java classes should be package-private with no modifier specified. |
swankjesse
added a commit
that referenced
this pull request
Jun 5, 2015
…cted Revert Call to a protected class instead of package-private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitoring libraries such as New Relic need to have the ability to subclass certain interesting classes in order to provide effective instrumentation. In previous versions of Okhttp, the Call constructor was protected, but it seems this changed in v2.4. This commit reverts Call from package-private to protected to allow for instrumentation.