Add optional Response to WS failure callback. #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the explicit Request from WS open callback. It can be accessed by calling 'request()' on the supplied Response.
JakeWharton
force-pushed
the
jw/ws-response
branch
from
675aef4
to
8e25853
Compare
swankjesse
added a commit
that referenced
this pull request
May 21, 2015
Add optional Response to WS failure callback.
|
Thanks for this Jake! Was just about to push essentially the exact same change. We're already running it from a 2.3 fork with good results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the explicit Request from WS open callback. It can be accessed by calling 'request()' on the supplied Response.
Closes #1639.