Change MockResponse body to Source. #1286
Merged
+28
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw/response-body-source
branch
2 times, most recently
from
26aab7e
to
87a1537
Compare
|
Sigh. More hanging tests. |
| * The number of bytes in {@linkplain #getBody() the body}. Note: this is not synonymous with | ||
| * {@code Content-Length} (e.g., in the case of chunked body). | ||
| */ | ||
| public long getBodySize() { |
There was a problem hiding this comment.
Looks like we only ever compare this to 0. Perhaps instead we could just have a null response from body source? The fact that this doesn't line up with Content-Length is ugly.
|
LGTM |
JakeWharton
force-pushed
the
jw/response-body-source
branch
6 times, most recently
from
a46c191
to
7d1c7e1
Compare
|
I went full-buffer which means you can stream anymore. Do we care? The problem is that some tests re-enqueue the same |
|
Let's kill one-shot streaming responses. They were there for testing large payloads. |
JakeWharton
force-pushed
the
jw/response-body-source
branch
from
7d1c7e1
to
9a5670b
Compare
JakeWharton
added a commit
that referenced
this pull request
Jan 5, 2015
Change MockResponse body to Source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.