Fix a bug where the response cache could be corrupted. #1102
+2,749
−845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code reviewer warning!GitHub might not be showing the big changes to CacheTest, which is where the bulk of the test refactoring lives. The |
| // TODO source.copyTo(cacheBody, byteCount); | ||
| cacheBody.write(source.clone(), byteCount); | ||
| // TODO source.copyTo(cacheBody, source.size() - byteCount, byteCount) | ||
| Buffer sourceCopy = source.clone(); |
|
nit: CacheTest.java line 1536: over 100 cols |
|
btw I reviewed it on IJ since github won't help. |
|
LGTM |
When streaming a response, we copy data from our buffer to the cached file on disk. Unfortunately we were copying N bytes from the front of the buffer when we wanted N bytes from the back of the buffer. Typically these are the same, but certain access patterns can cause them to be different, corrpting the cached file on disk. This was uncovered by migrating the cache tests from operating on HttpURLConnection's API to our new API.
swankjesse
force-pushed
the
jwilson_1025_fix_cache_bug
branch
from
64b6f08
to
f80b1f3
Compare
swankjesse
added a commit
that referenced
this pull request
Oct 27, 2014
Fix a bug where the response cache could be corrupted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When streaming a response, we copy data from our buffer to the cached file
on disk. Unfortunately we were copying N bytes from the front of the buffer
when we wanted N bytes from the back of the buffer.
Typically these are the same, but certain access patterns can cause them
to be different, corrpting the cached file on disk.
This was uncovered by migrating the cache tests from operating on
HttpURLConnection's API to our new API.