Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: small breaking refactors and bug fixes #148

Merged
merged 5 commits into from
Oct 4, 2021
Merged

fix!: small breaking refactors and bug fixes #148

merged 5 commits into from
Oct 4, 2021

Conversation

pretzelhammer
Copy link
Collaborator

@pretzelhammer pretzelhammer commented Sep 29, 2021 •
edited
Loading

Describe the problem this PR addresses

Using v6 as an opportunity to clean up our issues backlog and implement a handful of small breaking refactors and bug fixes which we can throw into a single major release. The goal of this major is to resolve these issues:

Describe the changes in this PR

described above

Other information

4.x to 5.x Migration Guide

This should have been written as part of this PR but here it is anyway:

  • MNoticeButton component has been removed, if you were using MNoticeButton component before you should replace it with the new MTextButton component

5.x to 6.x Migration Guide

  • MSection has been removed, if you were using it before you should replace it with the MContainer component and set the MContainer's bg-color prop to #fff.

@pretzelhammer
fix(section)!: removes deprecated and redundant MSection component (u… (
8bfef2f 
#146)

* fix(section)!: removes deprecated and redundant MSection component (use MContainer now)

* docs(container): tidies up container docs

* refactor: lint fixes
@github-actions
Copy link

Styleguide deployed to https://square.github.io/maker/styleguide/v6/#/

@github-actions
Copy link

github-actions bot commented Sep 29, 2021 •
edited
Loading

📊 Package size report   -1.62%↓

File Before After
components/Button/script.js 7.4 kB -0.2%↓7.4 kB
components/Button/styles.css 5.0 kB 1%↑5.0 kB
components/Calendar/script.js 7.5 kB 0.03%↑7.5 kB
components/Container/script.js 3.2 kB 35%↑4.3 kB
components/Section/index.js 46 B —
components/Section/script.js 3.2 kB —
components/Section/styles.css 1.0 kB —
components/Stepper/script.js 3.8 kB -2.24%↓3.7 kB
Total (Includes all files) 1.0 MB -1.62%↓1.0 MB
Tarball size 184.8 kB -0.73%↓183.4 kB
Unchanged files
File Size
components/ActionBar/index.js 46 B
components/ActionBar/script.js 13.1 kB
components/ActionBar/styles.css 5.9 kB
components/Blade/index.js 46 B
components/Blade/script.js 6.3 kB
components/Blade/styles.css 756 B
components/Button/index.js 46 B
components/Calendar/index.js 46 B
components/Calendar/styles.css 2.5 kB
components/Card/index.js 46 B
components/Card/script.js 1.7 kB
components/Card/styles.css 154 B
components/Checkbox/index.js 46 B
components/Checkbox/script.js 3.8 kB
components/Checkbox/styles.css 1.7 kB
components/Choice/index.js 46 B
components/Choice/script.js 4.3 kB
components/Choice/styles.css 1.3 kB
components/Container/index.js 46 B
components/Container/styles.css 1.0 kB
components/Dialog/index.js 46 B
components/Dialog/script.js 6.3 kB
components/Dialog/styles.css 1.0 kB
components/Divider/index.js 46 B
components/Divider/script.js 1.7 kB
components/Divider/styles.css 148 B
components/Heading/index.js 46 B
components/Heading/script.js 2.6 kB
components/Heading/styles.css 3.1 kB
components/Image/index.js 46 B
components/Image/script.js 3.4 kB
components/Image/styles.css 254 B
components/ImageUploader/index.js 46 B
components/ImageUploader/script.js 9.1 kB
components/ImageUploader/styles.css 1.6 kB
components/Input/index.js 46 B
components/Input/script.js 4.3 kB
components/Input/styles.css 3.1 kB
components/Loading/index.js 46 B
components/Loading/script.js 2.3 kB
components/Loading/styles.css 1.2 kB
components/Modal/index.js 46 B
components/Modal/script.js 7.8 kB
components/Modal/styles.css 969 B
components/Notice/index.js 46 B
components/Notice/script.js 4.3 kB
components/Notice/styles.css 1.0 kB
components/ProgressBar/index.js 46 B
components/ProgressBar/script.js 3.0 kB
components/ProgressBar/styles.css 1.1 kB
components/Radio/index.js 46 B
components/Radio/script.js 3.5 kB
components/Radio/styles.css 1.6 kB
components/SegmentedControl/index.js 46 B
components/SegmentedControl/script.js 3.1 kB
components/SegmentedControl/styles.css 813 B
components/Select/index.js 46 B
components/Select/script.js 5.1 kB
components/Select/styles.css 2.5 kB
components/Skeleton/index.js 46 B
components/Skeleton/script.js 4.4 kB
components/Skeleton/styles.css 817 B
components/StarRating/index.js 46 B
components/StarRating/script.js 6.0 kB
components/StarRating/styles.css 322 B
components/Stepper/index.js 46 B
components/Stepper/styles.css 384 B
components/Text/index.js 46 B
components/Text/script.js 2.1 kB
components/Text/styles.css 1.0 kB
components/Textarea/index.js 46 B
components/Textarea/script.js 3.7 kB
components/Textarea/styles.css 2.2 kB
components/Theme/index.js 25 B
components/Theme/script.js 2.3 kB
components/Toggle/index.js 46 B
components/Toggle/script.js 3.8 kB
components/Toggle/styles.css 3.6 kB
components/TransitionFadeIn/index.js 25 B
components/TransitionFadeIn/script.js 2.3 kB
components/TransitionResize/index.js 25 B
components/TransitionResize/script.js 3.7 kB
components/TransitionSpringLeft/index.js 25 B
components/TransitionSpringLeft/script.js 2.3 kB
components/TransitionSpringUp/index.js 25 B
components/TransitionSpringUp/script.js 2.3 kB
LICENSE 552 B
package.json 4.9 kB
README.md 327 B
utils/assert.js 767 B
utils/BlockFormControlLayout/index.js 46 B
utils/BlockFormControlLayout/script.js 1.8 kB
utils/BlockFormControlLayout/styles.css 333 B
utils/get-contrast.js 1.2 kB
utils/InlineFormControlLayout/index.js 46 B
utils/InlineFormControlLayout/script.js 2.5 kB
utils/InlineFormControlLayout/styles.css 355 B
utils/Transition/index.js 25 B
utils/Transition/script.js 2.5 kB
utils/TransitionResponsive/index.js 25 B
utils/TransitionResponsive/script.js 2.3 kB
utils/transitions.js 3.9 kB
Hidden files
File Before After
components/ActionBar/script.js.map 51.4 kB 51.4 kB
components/ActionBar/styles.css.map 16.6 kB 16.6 kB
components/Blade/script.js.map 23.4 kB 23.4 kB
components/Blade/styles.css.map 3.9 kB 3.9 kB
components/Button/script.js.map 30.9 kB 0.3%↑31.0 kB
components/Button/styles.css.map 13.9 kB 0.9%↑14.0 kB
components/Calendar/script.js.map 29.0 kB 0.01%↑29.0 kB
components/Calendar/styles.css.map 10.4 kB 0.02%↑10.4 kB
components/Card/script.js.map 8.8 kB 8.8 kB
components/Card/styles.css.map 668 B 668 B
components/Checkbox/script.js.map 18.4 kB 18.4 kB
components/Checkbox/styles.css.map 3.9 kB 3.9 kB
components/Choice/script.js.map 19.0 kB 19.0 kB
components/Choice/styles.css.map 5.7 kB 5.7 kB
components/Container/script.js.map 14.7 kB 15%↑17.0 kB
components/Container/styles.css.map 3.3 kB 41%↑4.6 kB
components/Dialog/script.js.map 23.6 kB 23.6 kB
components/Dialog/styles.css.map 4.4 kB 4.4 kB
components/Divider/script.js.map 8.8 kB 8.8 kB
components/Divider/styles.css.map 704 B 704 B
components/Heading/script.js.map 13.5 kB 13.5 kB
components/Heading/styles.css.map 5.5 kB 5.5 kB
components/Image/script.js.map 14.1 kB 14.1 kB
components/Image/styles.css.map 2.9 kB 2.9 kB
components/ImageUploader/script.js.map 37.4 kB 37.4 kB
components/ImageUploader/styles.css.map 16.4 kB 16.4 kB
components/Input/script.js.map 21.1 kB 21.1 kB
components/Input/styles.css.map 6.2 kB 6.2 kB
components/Loading/script.js.map 11.1 kB 11.1 kB
components/Loading/styles.css.map 2.3 kB 2.3 kB
components/Modal/script.js.map 28.7 kB 28.7 kB
components/Modal/styles.css.map 7.5 kB 7.5 kB
components/Notice/script.js.map 17.4 kB 17.4 kB
components/Notice/styles.css.map 3.8 kB 3.8 kB
components/ProgressBar/script.js.map 13.3 kB 13.3 kB
components/ProgressBar/styles.css.map 2.6 kB 2.6 kB
components/Radio/script.js.map 17.2 kB 17.2 kB
components/Radio/styles.css.map 3.7 kB 3.7 kB
components/Section/script.js.map 14.3 kB —
components/Section/styles.css.map 2.9 kB —
components/SegmentedControl/script.js.map 14.1 kB 14.1 kB
components/SegmentedControl/styles.css.map 3.3 kB 3.3 kB
components/Select/script.js.map 23.7 kB 23.7 kB
components/Select/styles.css.map 6.5 kB 6.5 kB
components/Skeleton/script.js.map 17.7 kB 17.7 kB
components/Skeleton/styles.css.map 2.9 kB 2.9 kB
components/StarRating/script.js.map 22.4 kB 22.4 kB
components/StarRating/styles.css.map 6.3 kB 6.3 kB
components/Stepper/script.js.map 16.1 kB -1.45%↓15.8 kB
components/Stepper/styles.css.map 3.3 kB -5.72%↓3.1 kB
components/Text/script.js.map 10.4 kB 10.4 kB
components/Text/styles.css.map 2.7 kB 2.7 kB
components/Textarea/script.js.map 18.5 kB 18.5 kB
components/Textarea/styles.css.map 4.8 kB 4.8 kB
components/Theme/script.js.map 10.8 kB 10.8 kB
components/Toggle/script.js.map 19.6 kB 19.6 kB
components/Toggle/styles.css.map 5.4 kB 5.4 kB
components/TransitionFadeIn/script.js.map 10.5 kB 10.5 kB
components/TransitionResize/script.js.map 14.5 kB 14.5 kB
components/TransitionSpringLeft/script.js.map 10.6 kB 10.6 kB
components/TransitionSpringUp/script.js.map 10.5 kB 10.5 kB
utils/assert.js.map 2.4 kB 2.4 kB
utils/BlockFormControlLayout/script.js.map 8.5 kB 8.5 kB
utils/BlockFormControlLayout/styles.css.map 902 B 902 B
utils/get-contrast.js.map 5.0 kB 5.0 kB
utils/InlineFormControlLayout/script.js.map 11.9 kB 11.9 kB
utils/InlineFormControlLayout/styles.css.map 1.2 kB 1.2 kB
utils/Transition/script.js.map 10.8 kB 10.8 kB
utils/TransitionResponsive/script.js.map 10.3 kB 10.3 kB
utils/transitions.js.map 14.1 kB 14.1 kB

🤖 This report was automatically generated by pkg-size-action

@pretzelhammer
fix(button): large, medium, small buttons should always be 64px, 48px…
b1400ab 
…, and 32px tall respectively (#147)
@pretzelhammer
fix(stepper)!: removes medium & large sizes on stepper, makes small s…
7a017af 
…ize the default (#145)
@pretzelhammer
feat(container): label & sublabel slots (#151)
d4992a4 
* feat(container): adds slots for label & sublabel, improves docs

* refactor(container): tiny changes in response to PR feedback
@pretzelhammer pretzelhammer marked this pull request as ready for review October 1, 2021 12:58
@pretzelhammer pretzelhammer requested a review from a team as a code owner October 1, 2021 12:58
@pretzelhammer pretzelhammer merged commit ba26504 into master Oct 4, 2021
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Oct 4, 2021
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenhu laurenhu laurenhu approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pretzelhammer @laurenhu