ignore leakcanary issue #297; AOSP issue #188551 #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update readme, goto SO
Link to Slack / HipChat gist
Reported in square#1
Ignoring 3 Android leaks
* Heap dumps and analysis results were previously saved in the app directory. They are now saved on the external storage (sd card). * Centralized internal static helper methods to a dedicated class: `LeakCanaryInternals`. BREAKING CHANGES * When upgrading, previously saved heap dumps will be lost, but won't be removed from the app directory. You should probably uninstall your app. * Added permission WRITE_EXTERNAL_STORAGE * Public API change: Removed `Application` parameter in `LeakCanary.androidWatcher()` * Public API change: Removed `Application` parameter in `AndroidHeapDumper()` * Fixes square#21 (can't share heap dump) * This is a step towards fixing square#15 (strict mode violations), although there's still more work.
* ExcludedRef is immutable, added ExcludedRef.Builder to create one. * AndroidExcludedRef returns a ExcludedRef.Builder * ExcludedRef is Serializable and belongs to HeapDump, it now gets passed from the RefWatcher. This also makes the saved result more coherent. * Moved ExcludedRef from analyzer to watcher module Fix for square#12
Heap dumps on SD card
Customizable ExcludedRef
Ignoring SpellCheckerSessionListenerImpl leak
Tests did not compile, introduced by square#30 We need Travis (and I should run my builds locally...)
Fix unit tests
Because Samsung. Fixes square#32
This icon was entirely recreated as a vector asset in Affinity Designer. I can check in the source Affinity Designer or other vector variants as needed (PDF, SVG, etc.)
- Introduces a Ui class to hold methods and values useful to several views (colors, xfermodes, etc.) - Make Paints static where possible, this saves on memory and allocations, it may also help draw batching - Set Paints’ antialiasing flag at instantiation time - Use a switch on connector type instead of an if. It is safer and since Type is an enum, we get the static imports for free
Fix for square#37
Fix NPE on cleanup
This change also moves a setStrokeWidth() from onDraw() to a constructor, as discussed in code review
* HAHA 1.2 has no .properties resource file which should fix square#46
Update to HAHA 1.2
Change DefaultAnalysisResultService to DisplayLeakService
marginLeft -> marginStart marginRight -> marginEnd
Fix lint warnings in res/layout/leak_canary_ref_row.xml
…ager Add fix suggestion for ClipboardUIManager leak.
Don't crash when heap dump fails square#226
Protect DisplayLeakActivity.setTheme() from receiving an incompatible theme
| // dialog has been closed and as a result leaks the Activity. | ||
| // This can be fixed manually by calling setCursorEnabled(false) in the dismiss() method of | ||
| // the dialog | ||
| excluded.instanceField("android.widget.EditText", "mContext"); |
There was a problem hiding this comment.
Let's be more specific, ie "android.widget.Editor$Blink", "this$0" instead.
|
Can you squash all 4 commits to 1, and also sign the CLA? https://github.com/square/leakcanary/blob/master/CONTRIBUTING.md |
|
I signed the CLA. |
|
I also squashed all 4 commits to 1. |
|
Something went wrong here. I only want commit 845eb60 to be merged. None of the other commits. |
|
I took your commit, applied the changes I was asking for, and created a new clean PR for it: #457 . It'll still be in your name :) . |
|
Thanks, I'll do better next time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.