Remove old references to "__" prefixed resources initiated by #159 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,7 +52,7 @@ Snapshots are available in Sonatype's `snapshots` repository: | |||
| * Added LeakCanary version name to `LeakCanary.leakInfo()`: [#49](https://github.com/square/leakcanary/issues/49). | |||
| * `leakcanary-android-no-op` is lighter, it does not depend on `leakcanary-watcher` anymore, only 2 classes now: [#74](https://github.com/square/leakcanary/issues/74). | |||
| * Adding field state details to the text leak trace. | |||
| * A Toast is displayed while the heap dump is in progress to warn that the UI will freeze: [#20](https://github.com/square/leakcanary/issues/49). You can customize the toast by providing your own layout named `__leak_canary_heap_dump_toast.xml` (e.g. you could make it an empty layout). | |||
| * A Toast is displayed while the heap dump is in progress to warn that the UI will freeze: [#20](https://github.com/square/leakcanary/issues/49). You can customize the toast by providing your own layout named `leak_canary_heap_dump_toast.xml` (e.g. you could make it an empty layout). | |||
There was a problem hiding this comment.
Nope. These are the change logs for 1.3.1, which wont' change what so ever.
CHANGELOG shouldn't be modified for previous version
|
Sorry for the delay. I think the best way forward is to duplicate info in the readme, until 1.4 is released. The changelog for 1.4 should be updated though. |
|
I cherry picked your commit, rebased it, made the changes I wanted, then opened another PR: #477. The commit will still be in your name :) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.md as well as CHANGELOG.md
Removed prefixes from internal layouts.
And finally, the leakcanary-sample module was still using this prefix to override the Activity label.