This repository was archived by the owner on Nov 19, 2025. It is now read-only.
Repository navigation
Make the Kotlin indent 2 spaces. - #51
Merged
swankjesse merged 1 commit intoJan 30, 2018
Merged
Conversation
rjrjr
approved these changes
Jan 30, 2018
|
Update Square.xml for now as well? |
These options haven't shown up before. I used Export from the settings dialog this time instead of just copying the file from the preferences directory.
zach-klippenstein
force-pushed
the
zachklipp/kotlin-indent-2-spaces
branch
from
January 30, 2018 18:17
c3d41d4 to
2a1c355
Compare
Contributor
Author
|
@NightlyNexus Fixed. |
Contributor
|
In #47 the indentation change to 4 spaces to follow Google Kotlin Android Style Guide, so why change it to 2 spaces now? |
Collaborator
|
Why change it to 4 when you have hundreds of thousands of existing lines of Kotlin and Java which are 2? |
ryanhall07
pushed a commit
to cashapp/misk
that referenced
this pull request
Feb 17, 2018
The majority of the diff noise comes from square/java-code-styles#51 which changed indent spacing from 4 to 2. This was done with the auto reformatter in Intellij
ryanhall07
pushed a commit
to cashapp/misk
that referenced
this pull request
Feb 17, 2018
Most of the noise is coming from the change to indent spaces 2 instead of the Kotlin standard of 4. square/java-code-styles#51 This is causing a lot of local diff noise when developing, so figured one giant change was better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These options haven't shown up before. I used Export from the settings dialog this time instead of just copying the file from the preferences directory.