Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

History.Builder no longer loses internal state #86

Merged
merged 2 commits into from
May 1, 2015

Conversation

loganj
Copy link
Collaborator

@loganj loganj commented May 1, 2015

It is now safe to pop objects off of a builder and then push them back
onto the same builder without losing internal state.

Also added Builder#clear, a convenience method for clearing the stack
while preserving internal state.

Flow has been updated to use History appropriately to preserve state.

@@ -33,4 +33,6 @@ android.libraryVariants.all { variant ->
}
}

apply from: '../gradle-mvn-push.gradle'
if (hasProperty("POM_DEVELOPER_ID")) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add your own uploadArchive task that explains why it's not working.

@rjrjr
Copy link
Collaborator

rjrjr commented May 1, 2015

Just nits, LGTM

loganj added 2 commits May 1, 2015 16:55
It is now safe to pop objects off of a builder and then push them back
onto the same builder without losing internal state.

Also added Builder#clear, a convenience method for clearing the stack
while preserving internal state.

Flow has been updated to use History appropriately to preserve state.
@loganj loganj force-pushed the loganj/remember_internal_state branch from 165293b to ea3a2fc Compare May 1, 2015 23:55
loganj added a commit that referenced this pull request May 1, 2015
History.Builder no longer loses internal state
@loganj loganj merged commit fca5c4c into master May 1, 2015
@loganj loganj deleted the loganj/remember_internal_state branch May 1, 2015 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants